Issue 126092: Begin to upgrade BackForwardMenuModelViews to use new menu API....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126092: Begin to upgrade BackForwardMenuModelViews to use new menu API.... (Closed)

Created:
11 years, 6 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Upgrade BackForwardMenuModelViews to use new menu API. Also adds accelerator to the "Show Full History" item. This requires bringing the owner-draw system for native menus over from the old code. I haven't really changed anything in it other than the format of dwItemData. This code could be improved/simplified by using gfx::Canvas more, but don't want to do it here. BUG=none TEST=make sure BackForwardMenuModel tests still pass, test the menu functionality in the toolbar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18454

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+302 lines, -141 lines)			Patch
M	chrome/browser/back_forward_menu_model.h	View		3 chunks	+5 lines, -12 lines	1 comment	Download
M	chrome/browser/back_forward_menu_model.cc	View		8 chunks	+21 lines, -9 lines	0 comments	Download
M	chrome/browser/back_forward_menu_model_unittest.cc	View		3 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/back_forward_menu_model_views.h	View	1	1 chunk	+30 lines, -12 lines	0 comments	Download
M	chrome/browser/back_forward_menu_model_views.cc	View	1	1 chunk	+65 lines, -30 lines	0 comments	Download
M	chrome/browser/gtk/back_forward_menu_model_gtk.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	views/controls/button/button_dropdown.h	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	views/controls/button/button_dropdown.cc	View		4 chunks	+8 lines, -25 lines	0 comments	Download
M	views/controls/menu/menu_2.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	views/controls/menu/native_menu_win.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/controls/menu/native_menu_win.cc	View	1	9 chunks	+146 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 6 months ago (2009-06-15 15:50:49 UTC) #2

LGTM

http://codereview.chromium.org/126092/diff/1013/22
File chrome/browser/back_forward_menu_model.h (right):

http://codereview.chromium.org/126092/diff/1013/22#newcode129
Line 129: Browser* browser_;
nit: while you're here, could you move the members after the functions.

Expand Messages | Collapse Messages