Change extension id format back to mp-decimal, and change the

Change extension id format back to mp-decimal, and change the
length to 32 chars (exactly 128 bits).

[Matt Perry, 2009-06-12 23:56:16]

couple nits, then LGTM

http://codereview.chromium.org/126074/diff/21/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/126074/diff/21/1003#newcode584
Line 584: if (!Extension::IdIsValid(extension_id)) {
move this below the kUnpackExtensionDir check so we don't whine about those.

http://codereview.chromium.org/126074/diff/21/1004
File chrome/browser/extensions/extensions_service_unittest.cc (right):

http://codereview.chromium.org/126074/diff/21/1004#newcode42
Line 42: const char* const theme2_crx = "pjpgmfcmabopnnfonnhmdjglfpjjfkbf";
Ha! awesome!

http://codereview.chromium.org/126074/diff/21/1005
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/126074/diff/21/1005#newcode47
Line 47: (*id)[i] = kIdAlphabet[HexStringToInt(id->substr(i, 1))];
how about HexStringToInt(bla) + 'a'?  then you could get rid of your ugly
alphabet array.

http://codereview.chromium.org/126074/diff/21/1005#newcode214
Line 214: if (id[i] < kIdAlphabet[0] || id[i] > kIdAlphabet[sizeof(kIdAlphabet)
- 1])
use arraysize instead of sizeof for arrays

[Aaron Boodman, 2009-06-13 00:26:30]

fyi

http://codereview.chromium.org/126074/diff/21/1003
File chrome/browser/extensions/extensions_service.cc (right):

http://codereview.chromium.org/126074/diff/21/1003#newcode584
Line 584: if (!Extension::IdIsValid(extension_id)) {
On 2009/06/12 23:56:16, Matt Perry wrote:
> move this below the kUnpackExtensionDir check so we don't whine about those.

Done.

http://codereview.chromium.org/126074/diff/21/1005
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/126074/diff/21/1005#newcode47
Line 47: (*id)[i] = kIdAlphabet[HexStringToInt(id->substr(i, 1))];
On 2009/06/12 23:56:16, Matt Perry wrote:
> how about HexStringToInt(bla) + 'a'?  then you could get rid of your ugly
> alphabet array.

Good idea, done.

http://codereview.chromium.org/126074/diff/21/1005#newcode214
Line 214: if (id[i] < kIdAlphabet[0] || id[i] > kIdAlphabet[sizeof(kIdAlphabet)
- 1])
On 2009/06/12 23:56:16, Matt Perry wrote:
> use arraysize instead of sizeof for arrays

Not necessary anymore.

[Matt Perry, 2009-06-13 00:30:59]

http://codereview.chromium.org/126074/diff/24/1013
File chrome/common/extensions/extension_unittest.cc (right):

http://codereview.chromium.org/126074/diff/24/1013#newcode259
Line 259: 0x30, 0x81, 0x9f, 0x30, 0x0d, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86,
0xf7, 0x0d, 0x01, 0x01, 0x01,
line length

http://codereview.chromium.org/126074/diff/24/1013#newcode274
Line 274: std::string(reinterpret_cast<const char*>(&public_key_info[0]),
line length