Issue 12607: It was brought to my attention that defining _HAS_TR1=0 helps with Visual Stu...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12607: It was brought to my attention that defining _HAS_TR1=0 helps with Visual Stu... (Closed)

Created:
12 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

It was brought to my attention that defining _HAS_TR1=0 helps with Visual Studio 2008 compilation and causes no adverse effect on Visual Studio 2005. Thanks to Daniel A. White for the tip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5959

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	build/internal/essential.scons	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/internal/essential.vsprops	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages