Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/renderer/render_view.cc

Issue 126067: Fix a bug where clicking an external link from an extension page would reuse... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/render_view.h" 5 #include "chrome/renderer/render_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1414 matching lines...) Expand 10 before | Expand all | Expand 10 after
1425 1425
1426 // We only care about navigations that are within the current tab (as opposed 1426 // We only care about navigations that are within the current tab (as opposed
1427 // to, for example, opening a new window). 1427 // to, for example, opening a new window).
1428 // But we sometimes navigate to about:blank to clear a tab, and we want to 1428 // But we sometimes navigate to about:blank to clear a tab, and we want to
1429 // still allow that. 1429 // still allow that.
1430 if (disposition == CURRENT_TAB && is_content_initiated && 1430 if (disposition == CURRENT_TAB && is_content_initiated &&
1431 frame->GetParent() == NULL && !url.SchemeIs(chrome::kAboutScheme)) { 1431 frame->GetParent() == NULL && !url.SchemeIs(chrome::kAboutScheme)) {
1432 // When we received such unsolicited navigations, we sometimes want to 1432 // When we received such unsolicited navigations, we sometimes want to
1433 // punt them up to the browser to handle. 1433 // punt them up to the browser to handle.
1434 if (BindingsPolicy::is_dom_ui_enabled(enabled_bindings_) || 1434 if (BindingsPolicy::is_dom_ui_enabled(enabled_bindings_) ||
1435 BindingsPolicy::is_extension_enabled(enabled_bindings_) ||
1435 frame->GetInViewSourceMode() || 1436 frame->GetInViewSourceMode() ||
1436 url.SchemeIs(chrome::kViewSourceScheme)) { 1437 url.SchemeIs(chrome::kViewSourceScheme)) {
1437 OpenURL(webview, url, GURL(), disposition); 1438 OpenURL(webview, url, GURL(), disposition);
1438 return IGNORE_ACTION; // Suppress the load here. 1439 return IGNORE_ACTION; // Suppress the load here.
1439 } 1440 }
1440 } 1441 }
1441 1442
1442 // Detect when a page is "forking" a new tab that can be safely rendered in 1443 // Detect when a page is "forking" a new tab that can be safely rendered in
1443 // its own process. This is done by sites like Gmail that try to open links 1444 // its own process. This is done by sites like Gmail that try to open links
1444 // in new windows without script connections back to the original page. We 1445 // in new windows without script connections back to the original page. We
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
2853 // If id is valid, alert the browser side that an accessibility focus change 2854 // If id is valid, alert the browser side that an accessibility focus change
2854 // occurred. 2855 // occurred.
2855 if (acc_obj_id >= 0) 2856 if (acc_obj_id >= 0)
2856 Send(new ViewHostMsg_AccessibilityFocusChange(routing_id_, acc_obj_id)); 2857 Send(new ViewHostMsg_AccessibilityFocusChange(routing_id_, acc_obj_id));
2857 2858
2858 #else // defined(OS_WIN) 2859 #else // defined(OS_WIN)
2859 // TODO(port): accessibility not yet implemented 2860 // TODO(port): accessibility not yet implemented
2860 NOTIMPLEMENTED(); 2861 NOTIMPLEMENTED();
2861 #endif 2862 #endif
2862 } 2863 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698