Cleanups from post-submit suggestions.

Cleanups from post-submit suggestions.

[Mark Mentovai, 2009-06-12 17:43:15]

http://codereview.chromium.org/126062/diff/1/2
File build/linux/dump_app_syms (right):

http://codereview.chromium.org/126062/diff/1/2#newcode36
Line 36: fi
This conditional should wrap the whole rest of the script, right?

[Michael Moss, 2009-06-12 17:55:20]

> This conditional should wrap the whole rest of the script, right?

It could, though I suppose there's a corner case where dump_signature.py changes
but chrome is not rebuilt, so we don't regenerate $OUTFILE, but want to update
it with a $NEWSIG. Then again, this isn't captured by the current gyp because I
didn't put dump_signature.py in the "inputs" of dump_symbols. Added.

Also added suggested fixes to dump_signature.py.

[Mark Mentovai, 2009-06-12 19:12:27]

LGTM, thanks for the follow-up.

http://codereview.chromium.org/126062/diff/1015/19
File build/linux/dump_signature.py (right):

http://codereview.chromium.org/126062/diff/1015/19#newcode29
Line 29: struct.unpack('I2H8B',struct.pack('16B',*signature)))
Spaces after commas (you copied/pasted my style error.)