Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Side by Side Diff: gcl.py

Issue 126057: Really really fix gcl.py (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 # 5 #
6 # Wrapper script around Rietveld's upload.py that groups files into 6 # Wrapper script around Rietveld's upload.py that groups files into
7 # changelists. 7 # changelists.
8 8
9 import getpass 9 import getpass
10 import os 10 import os
(...skipping 782 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 else: # First time we upload. 793 else: # First time we upload.
794 handle, desc_file = tempfile.mkstemp(text=True) 794 handle, desc_file = tempfile.mkstemp(text=True)
795 os.write(handle, change_info.description) 795 os.write(handle, change_info.description)
796 os.close(handle) 796 os.close(handle)
797 797
798 # Watchlist processing -- CC people interested in this changeset 798 # Watchlist processing -- CC people interested in this changeset
799 # http://dev.chromium.org/developers/contributing-code/watchlists 799 # http://dev.chromium.org/developers/contributing-code/watchlists
800 if not no_watchlists: 800 if not no_watchlists:
801 import watchlists 801 import watchlists
802 watchlist = watchlists.Watchlists(change_info.GetLocalRoot()) 802 watchlist = watchlists.Watchlists(change_info.GetLocalRoot())
803 watchers = watchlist.GetWatchersForPaths(change_info.GetFiles()) 803 watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames())
804 804
805 cc_list = GetCodeReviewSetting("CC_LIST") 805 cc_list = GetCodeReviewSetting("CC_LIST")
806 if not no_watchlists and watchers: 806 if not no_watchlists and watchers:
807 # Filter out all empty elements and join by ',' 807 # Filter out all empty elements and join by ','
808 cc_list = ','.join(filter(None, [cc_list] + watchers)) 808 cc_list = ','.join(filter(None, [cc_list] + watchers))
809 if cc_list: 809 if cc_list:
810 upload_arg.append("--cc=" + cc_list) 810 upload_arg.append("--cc=" + cc_list)
811 upload_arg.append("--description_file=" + desc_file + "") 811 upload_arg.append("--description_file=" + desc_file + "")
812 if change_info.description: 812 if change_info.description:
813 subject = change_info.description[:77] 813 subject = change_info.description[:77]
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 # the files. This allows commands such as 'gcl diff xxx' to work. 1192 # the files. This allows commands such as 'gcl diff xxx' to work.
1193 args =["svn", command] 1193 args =["svn", command]
1194 root = GetRepositoryRoot() 1194 root = GetRepositoryRoot()
1195 args.extend([os.path.join(root, x) for x in change_info.GetFileNames()]) 1195 args.extend([os.path.join(root, x) for x in change_info.GetFileNames()])
1196 RunShell(args, True) 1196 RunShell(args, True)
1197 return 0 1197 return 0
1198 1198
1199 1199
1200 if __name__ == "__main__": 1200 if __name__ == "__main__":
1201 sys.exit(main()) 1201 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698