Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: presubmit_canned_checks.py

Issue 126050: Write the command to execute in the error message so people don't have to learn how svn works. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index dd3313196c137438f98d45859ee891f148ac1e7d..138ed75bf2cebb314878462775862f62d3ba9fc6 100755
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -194,10 +194,12 @@ def CheckChangeSvnEolStyle(input_api, output_api, source_file_filter=None):
if bad:
if input_api.is_committing:
return [output_api.PresubmitError(
- "Fix these files with svn svn:eol-style=LF", items=bad)]
+ "Run `svn pset svn:eol-style LF <item>` on these files:",
+ items=bad)]
else:
return [output_api.PresubmitNotifyResult(
- "Fix these files with svn svn:eol-style=LF", items=bad)]
+ "Run `svn pset svn:eol-style LF <item>` on these files:",
+ items=bad)]
return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698