Issue 126032: Fix 'gcl settings' output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126032: Fix 'gcl settings' output. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix 'gcl settings' output. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18265

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	gcl.py	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 6 months ago (2009-06-12 02:43:29 UTC) #2

LGTM

http://codereview.chromium.org/126032/diff/1/2
File gcl.py (right):

http://codereview.chromium.org/126032/diff/1/2#newcode1119
Line 1119: del CODEREVIEW_SETTINGS['__just_initialized']
really? del?  can't you use like .erase, or something like that?

Expand Messages | Collapse Messages