Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2317)

Unified Diff: base/process_util_mac.mm

Issue 126011: Update the comments on why these really can't be done, and remove the notimpl... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_mac.mm
===================================================================
--- base/process_util_mac.mm (revision 18193)
+++ base/process_util_mac.mm (working copy)
@@ -227,30 +227,31 @@
return filter_->Includes(entry_.pid, entry_.ppid);
}
+
+// ------------------------------------------------------------------------
+// NOTE: about ProcessMetrics
+//
+// Mac doesn't have /proc, and getting a mach task from a pid for another
+// process requires permissions, so there doesn't really seem to be a way
+// to do these (and spinning up ps to fetch each stats seems dangerous to
+// put in a base api for anyone to call.
+//
bool ProcessMetrics::GetIOCounters(IoCounters* io_counters) const {
- // TODO(pinkerton): can we implement this? On linux it relies on /proc.
- NOTIMPLEMENTED();
return false;
}
-
size_t ProcessMetrics::GetPagefileUsage() const {
- NOTIMPLEMENTED();
return 0;
}
-
size_t ProcessMetrics::GetPeakPagefileUsage() const {
- NOTIMPLEMENTED();
return 0;
}
-
size_t ProcessMetrics::GetWorkingSetSize() const {
- NOTIMPLEMENTED();
return 0;
}
-
size_t ProcessMetrics::GetPeakWorkingSetSize() const {
- NOTIMPLEMENTED();
return 0;
}
+// ------------------------------------------------------------------------
+
} // namespace base
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698