Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1256002: Add a test to verify correctness of remembered set update for Heap::CopyJSObject. (Closed)

Created:
10 years, 9 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a test to verify correctness of remembered set update for Heap::CopyJSObject. Committed: http://code.google.com/p/v8/source/detail?r=4286

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing Mads' comments #

Patch Set 3 : Forgotten dot. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -1 line) Patch
M src/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
antonm
Mads, Kasper, may you have a look? It's monstrous and still doesn't guarantee to check ...
10 years, 9 months ago (2010-03-24 14:47:55 UTC) #1
Mads Ager (chromium)
Anton, can you force a full compacting GC at the beginning of this test to ...
10 years, 9 months ago (2010-03-25 09:42:08 UTC) #2
antonm
<quote> Anton, can you force a full compacting GC at the beginning of this test ...
10 years, 9 months ago (2010-03-25 14:42:45 UTC) #3
Mads Ager (chromium)
10 years, 9 months ago (2010-03-25 15:02:59 UTC) #4
LGTM

This is hairy, but it is good to have a test for this.  You have comments
explaining what is going on so we will have some info to go on if this one
starts failing.

Powered by Google App Engine
This is Rietveld 408576698