Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 125259: Now update git depot_tools checkouts, also add automatic update for git-cl-repo and git-try-repo. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Now update git depot_tools checkouts, also add automatic update for git-cl-repo and git-try-repo. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18633

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M bootstrap/gclient.sh View 1 chunk +0 lines, -17 lines 0 comments Download
M gclient View 2 chunks +22 lines, -7 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
bootstrap/gclient.sh was totally useless since bash cache the file in memory (unlike cmd).
11 years, 6 months ago (2009-06-17 15:54:59 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/125259/diff/1/3 File gclient (right): http://codereview.chromium.org/125259/diff/1/3#newcode13 Line 13: (cd "$base_dir"; git svn fetch -q; git ...
11 years, 6 months ago (2009-06-17 17:31:01 UTC) #2
M-A Ruel
On 2009/06/17 17:31:01, Evan Martin wrote: > http://codereview.chromium.org/125259/diff/1/3 > File gclient (right): > > http://codereview.chromium.org/125259/diff/1/3#newcode13 ...
11 years, 6 months ago (2009-06-17 17:58:06 UTC) #3
Evan Martin
11 years, 6 months ago (2009-06-17 18:00:13 UTC) #4
On 2009/06/17 17:58:06, Marc-Antoine Ruel wrote:
> On 2009/06/17 17:31:01, Evan Martin wrote:
> > http://codereview.chromium.org/125259/diff/1/3
> > File gclient (right):
> > 
> > http://codereview.chromium.org/125259/diff/1/3#newcode13
> > Line 13: (cd "$base_dir"; git svn fetch -q; git merge trunk -q)
> > you can just do "git svn rebase -q" i guess, rather than fetch/merge
> 
> Won't git svn rebase -q fail if there is local modifications?

merge will fail too, in that case.

Powered by Google App Engine
This is Rietveld 408576698