Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 125256: Implemented processing of compressed log files. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implemented processing of compressed log files. - fixed address delta calculation; - code creations are also compressed to be in sync with other events; - factored out a base class from TickProcessor to reuse code in DevTools profiler. Committed: http://code.google.com/p/v8/source/detail?r=2216

Patch Set 1 #

Patch Set 2 : Added tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -150 lines) Patch
M src/log.cc View 6 chunks +64 lines, -40 lines 0 comments Download
M src/log-utils.cc View 1 chunk +12 lines, -6 lines 0 comments Download
A test/mjsunit/tools/logreader.js View 1 chunk +82 lines, -0 lines 0 comments Download
M tools/linux-tick-processor View 1 chunk +1 line, -1 line 0 comments Download
A tools/logreader.js View 1 chunk +317 lines, -0 lines 2 comments Download
M tools/tickprocessor.js View 8 chunks +41 lines, -102 lines 0 comments Download
M tools/windows-tick-processor.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-17 15:09:10 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/125256/diff/9/1011 File tools/logreader.js (right): http://codereview.chromium.org/125256/diff/9/1011#newcode91 Line 91: return function addressParser (str) { Maybe add ...
11 years, 6 months ago (2009-06-18 06:57:44 UTC) #2
Mikhail Naganov
11 years, 6 months ago (2009-06-18 07:57:07 UTC) #3
http://codereview.chromium.org/125256/diff/9/1011
File tools/logreader.js (right):

http://codereview.chromium.org/125256/diff/9/1011#newcode91
Line 91: return function addressParser (str) {
On 2009/06/18 06:57:44, Søren Gjesse wrote:
> Maybe add parentheses arround the function returned 'return (function
> addressParser (str) { ... })' - can make it easier to see where it ends. Why
> does it have a name anyway?

Parentheses added. I thought that giving a name adds clarity, but as it confuses
instead, I've removed it.

Powered by Google App Engine
This is Rietveld 408576698