Issue 125246: DevTools: Fix crash on refresh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125246: DevTools: Fix crash on refresh. (Closed)

Created:
11 years, 6 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Fix crash on refresh. BUG=14221 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18608

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webkit/glue/webdevtoolsclient_impl.cc	View		1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yurys

11 years, 6 months ago (2009-06-17 11:43:39 UTC) #2

LGTM

http://codereview.chromium.org/125246/diff/1/2
File webkit/glue/webdevtoolsclient_impl.cc (right):

http://codereview.chromium.org/125246/diff/1/2#newcode70
Line 70: if (request.frame && request.frame->attached()) {
it should be if (request.frame.get()...
also put the line above into the if block

Expand Messages | Collapse Messages