Issue 125245: Optimize special cases of Math.pow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125245: Optimize special cases of Math.pow(). (Closed)

Created:
11 years, 6 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize special cases of Math.pow(). Committed: http://code.google.com/p/v8/source/detail?r=2201

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -2 lines)			Patch
	M	src/runtime.cc	View	1 2	1 chunk	+48 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-17 11:00:32 UTC) #2

LGTM.

http://codereview.chromium.org/125245/diff/6/7
File src/runtime.cc (right):

http://codereview.chromium.org/125245/diff/6/7#newcode4187
Line 4187: m *= m;
Can't you use m = pow(m, 2) here?

http://codereview.chromium.org/125245/diff/6/7#newcode4215
Line 4215: } else if (y == 0) {
I would move this test above y == +- 0.5.

Expand Messages | Collapse Messages