Issue 125201: Fix bug where the autocomplete text was being overridden by the user-entered text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125201: Fix bug where the autocomplete text was being overridden by the user-entered text. (Closed)

Created:
11 years, 6 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
jeremy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix bug where the autocomplete text was being overridden by the user-entered text. During the course of this, I gave in and implemented EmphasizeURLComponents() for consistency with Windows and GTK. Since modifying the text changes the selection, added SetTextAndSelectedRange() to make operations doing both easier to get right. Renamed UpdateAndStyleText() to SetText() for consistency. http://crbug.com/14122 TEST=See bug.

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -14 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.h	View		1 chunk	+10 lines, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/autocomplete_edit_view_mac.mm	View		8 chunks	+28 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

The very last change is actually the one which fixes the bug.

11 years, 6 months ago (2009-06-16 18:37:32 UTC) #1

lgtm

Expand Messages | Collapse Messages