Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 125192: Fix the problem with JS entries in tickprocessor. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Fix the problem with JS entries in tickprocessor. The main problem was due to the following: after Erik had fixed the logger to report library addresses, tickprocessor started to add to the code map entries that covered almost entire memory. This happened because tickprocessor contains a heuristic to bias addresses of functions from dynamic libraries: if (funcInfo.start < libStart && funcInfo.start < libEnd - libStart) { funcInfo.start += libStart; } And, as tickprocessor tried to process all symbols from the library, including data entries, which can be outside reported library addresses range, the second condition failed, and funcInfo.start remained unbiased. Committed: http://code.google.com/p/v8/source/detail?r=2194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/tickprocessor.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-16 16:25:22 UTC) #1
Erik Corry
11 years, 6 months ago (2009-06-16 18:20:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698