Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 125189: Added particle trails for things like exhaust on a car. (Closed)

Created:
11 years, 6 months ago by gman
Modified:
9 years, 7 months ago
Reviewers:
vangelis, apatrick
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Added particle trails for things like exhaust on a car. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19549

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -85 lines) Patch
M samples/o3djs/base.js View 1 chunk +11 lines, -0 lines 0 comments Download
M samples/o3djs/particles.js View 10 chunks +295 lines, -83 lines 4 comments Download
M samples/particles.html View 6 chunks +104 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gman
11 years, 6 months ago (2009-06-16 15:52:41 UTC) #1
apatrick
LGTM http://codereview.chromium.org/125189/diff/1/3 File samples/o3djs/particles.js (right): http://codereview.chromium.org/125189/diff/1/3#newcode695 Line 695: * @param {!o3d.Transform} opt_parent The parent for ...
11 years, 6 months ago (2009-06-16 18:12:57 UTC) #2
vangelis
11 years, 5 months ago (2009-06-30 00:07:37 UTC) #3
this change looks like it broke the particles sample in IE.

Powered by Google App Engine
This is Rietveld 408576698