Issue 125183: Fix profiling for shared libraries on Linux loaded at negative addresses...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125183: Fix profiling for shared libraries on Linux loaded at negative addresses... (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix profiling for shared libraries on Linux loaded at negative addresses (Android does this). Fix logging for executable mappings that have no file associated. Be more consistent with use of uintptr_t. Committed: http://code.google.com/p/v8/source/detail?r=2187

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -20 lines)			Patch
M	src/log.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+12 lines, -8 lines	0 comments	Download
M	src/platform-linux.cc	View	3 chunks	+19 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

11 years, 6 months ago (2009-06-16 12:45:53 UTC) #2

LGTM

Great! I noticed this problem on my machine too, but wasn't motivated enough to
fix it.

Expand Messages | Collapse Messages