Fix: New window appears to the left/up if the taskbar is on left/top....

chrome/browser/window_sizer.cc

Index: chrome/browser/window_sizer.cc
===================================================================
--- chrome/browser/window_sizer.cc	(revision 18780)
+++ chrome/browser/window_sizer.cc	(working copy)
@@ -151,6 +151,7 @@
   if (!state_provider_ || !state_provider_->GetLastActiveWindowState(bounds))
     return false;
   gfx::Rect last_window_bounds = *bounds;
+  bounds->Offset(monitor_info_provider_->GetBoundsOffsetMatching(*bounds));

[Peter Kasting, 2009/06/19 06:21:14]

So wait a minute.  I'm thinking about these more and they feel weird.

Why are we offsetting by the (work area - monitor rect) difference anyway?  Are
the previous bounds we retrieve offset opposite to this and we have to correct
for it?  I assume so... but then the values you get in your unittests kinda
scare me since we go from e.g. (10, 10) to (127, 10).  The only way this can be
right is if the first coordinate is relative to the work area and the second
relative to the screen.  Is that the case?

   bounds->Offset(kWindowTilePixels, kWindowTilePixels);
   AdjustBoundsToBeVisibleOnMonitorContaining(last_window_bounds, bounds);
   return true;
@@ -162,9 +163,7 @@
   if (!state_provider_ ||
       !state_provider_->GetPersistentState(bounds, maximized))
     return false;
-  const gfx::Point& taskbar_offset =
-      monitor_info_provider_->GetBoundsOffsetMatching(*bounds);
-  bounds->Offset(taskbar_offset.x(), taskbar_offset.y());
+  bounds->Offset(monitor_info_provider_->GetBoundsOffsetMatching(*bounds));
   AdjustBoundsToBeVisibleOnMonitorContaining(*bounds, bounds);
   return true;
 }