Issue 125164: Fix a bug where ExtensionHost and ExtensionView weren't getting closed proper...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125164: Fix a bug where ExtensionHost and ExtensionView weren't getting closed proper... (Closed)

Created:
11 years, 6 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry, rafaelw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a bug where ExtensionHost and ExtensionView weren't getting closed properly when a browser window was closed. BUG=13975 TEST=see bug for repro steps Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18470

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	chrome/browser/extensions/extension_view.h	View		4 chunks	+11 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_view.cc	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

LGTM with 2 comments. http://codereview.chromium.org/125164/diff/7/1002 File chrome/browser/extensions/extension_view.cc (right): http://codereview.chromium.org/125164/diff/7/1002#newcode26 Line 26: registrar_.RemoveAll(); do you need ...

11 years, 6 months ago (2009-06-16 00:50:32 UTC) #2

LGTM

Expand Messages | Collapse Messages