Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 125164: Fix a bug where ExtensionHost and ExtensionView weren't getting closed proper... (Closed)

Created:
11 years, 6 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Matt Perry, rafaelw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a bug where ExtensionHost and ExtensionView weren't getting closed properly when a browser window was closed. BUG=13975 TEST=see bug for repro steps Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18470

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M chrome/browser/extensions/extension_view.h View 4 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_view.cc View 1 2 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Erik does not do reviews
11 years, 6 months ago (2009-06-16 00:38:39 UTC) #1
Matt Perry
LGTM with 2 comments. http://codereview.chromium.org/125164/diff/7/1002 File chrome/browser/extensions/extension_view.cc (right): http://codereview.chromium.org/125164/diff/7/1002#newcode26 Line 26: registrar_.RemoveAll(); do you need ...
11 years, 6 months ago (2009-06-16 00:50:32 UTC) #2
rafaelw
11 years, 6 months ago (2009-06-16 00:52:13 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698