Issue 125162: Temporarily break the purify bot again so that I can get log

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125162: Temporarily break the purify bot again so that I can get log (Closed)

Created:
11 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Temporarily break the purify bot again so that I can get log entries needed to permanently fix.

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/extensions/extensions_service_unittest.cc	View		1 chunk	+4 lines, -0 lines	1 comment	Download
	M	chrome/test/data/purify/unit_tests.exe.gtest.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 6 months ago (2009-06-16 00:32:54 UTC) #2

LGTM

http://codereview.chromium.org/125162/diff/1/2
File chrome/browser/extensions/extensions_service_unittest.cc (right):

http://codereview.chromium.org/125162/diff/1/2#newcode521
Line 521: LOG(INFO) << "Private key:\n" << priv_key;
is log level set right on the bots?  or should this be LOG(WARNING)? (I honestly
don't know)

Expand Messages | Collapse Messages