Issue 125142: Move automated_ui_test_test to ui_tests from a library so it actually gets ru...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125142: Move automated_ui_test_test to ui_tests from a library so it actually gets ru... (Closed)

Created:
11 years, 6 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move automated_ui_test_test to ui_tests from a library so it actually gets run. Trivial tweaks to get most of it to build on Linux. BUG=none TEST=run ui_tests --gtest_filter=AutomatedUITestBase, verify that six to eight are enabled and all pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18460

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
M	chrome/chrome.gyp	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_base.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/automated_ui_tests/automated_ui_test_test.cc	View	4	4 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dank

These tests didn't seem to run by default, so I enabled them on all platforms, ...

11 years, 6 months ago (2009-06-15 21:36:18 UTC) #1

dank

Correction: I disable RestoreTab unconditionally because it's failing on the trybot (I see it's been ...

11 years, 6 months ago (2009-06-15 21:44:15 UTC) #2

LGTM. Thanks for the fix.

Expand Messages | Collapse Messages