Issue 125133: Make tooltips work correctly, allowing for multiple tooltips w/out the mouse ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125133: Make tooltips work correctly, allowing for multiple tooltips w/out the mouse ... (Closed)

Created:
11 years, 6 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan, Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make tooltips work correctly, allowing for multiple tooltips w/out the mouse leaving the view (which is all NSView can handle by itself). Adds some Camino code to do so. BUG=13995 TEST=tooltips in web pages, pages with multiple tooltips, expose and spaces. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18408

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+412 lines, -6 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_mac.h	View	3 chunks	+6 lines, -0 lines	1 comment	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	5 chunks	+32 lines, -6 lines	1 comment	Download
M	chrome/chrome.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	third_party/mozilla/include/NSScreen+Utils.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
A	third_party/mozilla/include/NSScreen+Utils.m	View	1 chunk	+59 lines, -0 lines	0 comments	Download
A	third_party/mozilla/include/ToolTip.h	View	1 chunk	+57 lines, -0 lines	0 comments	Download
A	third_party/mozilla/include/ToolTip.mm	View	1 chunk	+209 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

11 years, 6 months ago (2009-06-15 16:52:26 UTC) #3

LGTM with minor nits

http://codereview.chromium.org/125133/diff/1/6
File chrome/browser/renderer_host/render_widget_host_view_mac.h (right):

http://codereview.chromium.org/125133/diff/1/6#newcode140
Line 140: // leaving the view and NSView isn't set up for that to happen.
s/the view/a region/ to make it more clear why we aren't using  addToolTipRect:?

http://codereview.chromium.org/125133/diff/1/7
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/125133/diff/1/7#newcode260
Line 260: // still inside the view. Since the page elements that get tooltips
are all
s/the view/a region/

Expand Messages | Collapse Messages