Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 125131: X64 platform: Add more register allocator functions. (Closed)

Created:
11 years, 6 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64 platform: Add more register allocator functions. Committed: http://code.google.com/p/v8/source/detail?r=2177

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -7 lines) Patch
M src/SConscript View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +3 lines, -1 line 1 comment Download
M src/x64/register-allocator-x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/register-allocator-x64.cc View 1 1 chunk +63 lines, -0 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 1 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
William Hesse
Some little changes for you.
11 years, 6 months ago (2009-06-15 16:32:51 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/125131/diff/1/5 File src/x64/assembler-x64-inl.h (left): http://codereview.chromium.org/125131/diff/1/5#oldcode157 Line 157: intptr_t* p = reinterpret_cast<intptr_t*>(pc_ + 1); Why ...
11 years, 6 months ago (2009-06-16 08:19:49 UTC) #2
Kevin Millikin (Chromium)
http://codereview.chromium.org/125131/diff/19/1004 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/125131/diff/19/1004#newcode536 Line 536: // Advances rdx to the end of the ...
11 years, 6 months ago (2009-06-16 08:27:03 UTC) #3
William Hesse
11 years, 6 months ago (2009-06-16 11:45:26 UTC) #4
http://codereview.chromium.org/125131/diff/1/5
File src/x64/assembler-x64-inl.h (left):

http://codereview.chromium.org/125131/diff/1/5#oldcode157
Line 157: intptr_t* p = reinterpret_cast<intptr_t*>(pc_ + 1);
On 2009/06/16 08:19:50, Lasse Reichstein wrote:
> Why remove this? Is it not used by the debugger anyway?

It needs to be rewritten for the x64 platform, if needed, and it was breaking
the build of the new test.

Powered by Google App Engine
This is Rietveld 408576698