Issue 125130: Fix focus traversal cycle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125130: Fix focus traversal cycle. (Closed)

Created:
11 years, 6 months ago by Yuta Kitamura

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix focus traversal cycle. This change makes traversal order of focus cycle consistent between forward and backward traversal. This is a partial fix for issue 6785. BUG=http://crbug.com/6785 TEST=Move the focus to the find bar, and push [Shift]+[Tab]. The focus should not cycle inside the find bar, but go out to the omnibox (or somewhere outside the find bar). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18402

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -40 lines)			Patch
M	views/focus/focus_manager.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	views/focus/focus_manager.cc	View	1 chunk	+8 lines, -26 lines	0 comments	Download
M	views/focus/focus_manager_unittest.cc	View	3 chunks	+3 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuta Kitamura

Hi Jay, one more focus patch is here. Could you take your time to review ...

11 years, 6 months ago (2009-06-15 17:06:42 UTC) #1

Thanks!

Expand Messages | Collapse Messages