Issue 125126: Fix disassembly output from oprofile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125126: Fix disassembly output from oprofile (Closed)

Created:
11 years, 6 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mikhail Naganov, mnaganov (inactive)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix disassembly output from oprofile. Only send the inscructions part of a code object to oprofile when reporting dynamically generated code. Before the code object header was also reported to oprofile as code which caused strange disassembly output when using opannotate. Committed: http://code.google.com/p/v8/source/detail?r=2174

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	src/codegen.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/compiler.cc	View		2 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mikhail Naganov

11 years, 6 months ago (2009-06-15 15:10:11 UTC) #2

On 2009/06/15 15:05:48, Søren Gjesse wrote:
> 

LGTM!

Yes, it seems I forgot to update this code when changing regular logging code a
while ago.

Expand Messages | Collapse Messages