Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 125125: Fixed pointer vs. va_list overloading problem occuring in gcc 3.3 (used for ARM build). (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed pointer vs. va_list overloading problem occuring in gcc 3.3 (used for ARM build). It seems that when calling a method that has two overloaded versions like this: f(char* format, ...) f(char* format, va_list args) with a second pointer argument: f("format", pointer), the second version is picked up. I've found a description of a similar issue here: http://bugs.gentoo.org/63112 So, to resolve this ambiguity, I've named such LogMessageBuilder's Append functions differently. Committed: http://code.google.com/p/v8/source/detail?r=2172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log-utils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/log-utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-15 15:00:02 UTC) #1
Mads Ager (chromium)
11 years, 6 months ago (2009-06-15 15:46:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698