Start to get memory test compiling on mac & linux....

Start to get memory test compiling on mac & linux.
  Block some memory checks with #if defined(win) to get things compiling.
  Switch some things over to file paths.
Test doesn't work yet, but this atleast gets it compiling/linking now.

TEST=none
BUG=14098
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18418

[TVL, 2009-06-15 16:13:51]

I've confirmed this compiles on all three, but mac isn't close to passing,
something is causing automation to go off the deep dep end part way through, and
the memory logging is also gonna need some cleanup to get real stats on all
platforms, but I wanted to send this out so we can start building it on the bots
to help make sure it stays building and can be brought online later.

[Evan Martin, 2009-06-15 17:42:35]

http://codereview.chromium.org/125124/diff/7/8
File chrome/test/memory_test/memory_test.cc (right):

http://codereview.chromium.org/125124/diff/7/8#newcode21
Line 21: #if defined(OS_WIN)
TODO(port) here?

http://codereview.chromium.org/125124/diff/7/8#newcode32
Line 32: static const std::string kTempDirName("memory_test_profile");
No static objects, so the previous code was better.

Rather than this, I'd suggest either using FILE_PATH_LITERAL (see file_path.h)
or just making it a char kTempDirName[] = "..."; and using one of the ASCII
FilePath functions where it's needed.  I guess from the usage the former option
is better.  I kinda think CreateTempDir or whatever should just take an ascii
string as its arg instead of this wstring business.

http://codereview.chromium.org/125124/diff/7/8#newcode270
Line 270: PrintResults(test_name, 0);
NOTIMPLMENETED() here?

http://codereview.chromium.org/125124/diff/7/8#newcode391
Line 391: bool SetupTempDirectory(FilePath src_dir) {
const FilePath& ?

[TVL, 2009-06-15 18:36:45]

new version up

[Evan Martin, 2009-06-15 19:15:22]

LGTM

[Mark Mentovai, 2009-06-15 20:04:50]

lg