src/arm/codegen-arm.cc - Issue 125122: Two small fixes for the Math.sin and Math.cos optimizations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/codegen-arm.cc

Issue 125122: Two small fixes for the Math.sin and Math.cos optimizations. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/codegen-arm.cc

===================================================================

--- src/arm/codegen-arm.cc (revision 2166)

+++ src/arm/codegen-arm.cc (working copy)

@@ -3416,7 +3416,7 @@

void CodeGenerator::GenerateFastMathOp(MathOp op, ZoneList<Expression*>* args) {

VirtualFrame::SpilledScope spilled_scope;

- Load(args->at(0));

+ LoadAndSpill(args->at(0));

switch (op) {

case SIN:

__ CallRuntime(Runtime::kMath_sin, 1);

« no previous file with comments | « no previous file | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »