Optimize Math.sin and Math.cos by avoiding runtime calls.

Optimize Math.sin and Math.cos by avoiding runtime calls.

Committed: http://code.google.com/p/v8/source/detail?r=2166

[Kasper Lund, 2009-06-15 11:47:02]

If you fix the slow-case runtime call this LGTM.

http://codereview.chromium.org/125121/diff/1022/1023
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/125121/diff/1022/1023#newcode5008
Line 5008: Result answer = frame_->CallRuntime(Runtime::kMath_sin, 1);
This seems wrong. Shouldn't this be either kMath_sin or kMath_cos? Need better
tests?

[Mads Ager (chromium), 2009-06-15 12:05:26]

http://codereview.chromium.org/125121/diff/1022/1023
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/125121/diff/1022/1023#newcode5008
Line 5008: Result answer = frame_->CallRuntime(Runtime::kMath_sin, 1);
On 2009/06/15 11:47:02, Kasper Lund wrote:
> This seems wrong. Shouldn't this be either kMath_sin or kMath_cos? Need better
> tests?

Auch, thanks for spotting this.  I have added a regression test for it.

[Kevin Millikin (Chromium), 2009-06-15 12:08:48]

http://codereview.chromium.org/125121/diff/1022/1033
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/125121/diff/1022/1033#newcode3419
Line 3419: Load(args->at(0));
This should be a call to LoadAndSpill.

http://codereview.chromium.org/125121/diff/1022/1023
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/125121/diff/1022/1023#newcode4999
Line 4999: frame_->Pop();
There is a Drop function that doesn't go through the process of creating a
result (possibly allocating a register and moving a memory or constant value
into it), but see next.

http://codereview.chromium.org/125121/diff/1022/1023#newcode5001
Line 5001: frame_->Push(&heap_number);
You can and probably should replace these two with frame_->SetElementAt(0,
&heap_number) (and you don't need the Unuse).

[Mads Ager (chromium), 2009-06-15 12:14:42]

Thanks Kevin.  Both done (in a separate changelist since I went ahead and
committed this one).