Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 125114: Involve more log compression techniques. (Closed)

Created:
11 years, 6 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Involve more log compression techniques. Code addresses are now written as an offset from the previous address for ticks, code move and delete events. Employed backreference and RLE compression for code move and delete events. This gives additional 30% log size reduction for benchmarks run w/o snapshot. Overall compression results (compared with the revision of V8 having no compression): - V8: 70% size reduction for benchmarks run w/o snapshot (for reference, gzip gives 87%) - Chromium: 65% size reduction for public html version of benchmarks (v4) (for reference, gzip gives 90%) The one obvious opportunity for improving compression results in Chromium is to compress URLs of scripts. Committed: http://code.google.com/p/v8/source/detail?r=2162

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -175 lines) Patch
M src/log.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/log.cc View 13 chunks +96 lines, -67 lines 0 comments Download
M src/log-utils.h View 4 chunks +58 lines, -56 lines 0 comments Download
M src/log-utils.cc View 9 chunks +77 lines, -31 lines 0 comments Download
M test/cctest/test-log-utils.cc View 9 chunks +36 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mikhail Naganov
11 years, 6 months ago (2009-06-15 07:57:32 UTC) #1
Søren Thygesen Gjesse
LGTM I don't see a test of the encoding of the code addresses for ticks, ...
11 years, 6 months ago (2009-06-15 09:32:02 UTC) #2
Mikhail Naganov
11 years, 6 months ago (2009-06-15 09:37:19 UTC) #3
On 2009/06/15 09:32:02, Søren Gjesse wrote:
> LGTM
> 
> I don't see a test of the encoding of the code addresses for ticks, code move
> and delete events using offsets.

Thanks!

Yes, those tests are absent. But I'm not considering writing them in this CL,
because offsets compression is quite trivial.

Powered by Google App Engine
This is Rietveld 408576698