Issue 12511: Added the v8::jscre namespace around the jscre functions to avoid link errors...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12511: Added the v8::jscre namespace around the jscre functions to avoid link errors... (Closed)

Created:
12 years ago by iposva

Modified:
9 years, 3 months ago

Reviewers:
Erik does not do reviews, Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added the v8::jscre namespace around the jscre functions to avoid link errors (duplicate symbols) when building Google Chrome. Committed: http://code.google.com/p/v8/source/detail?r=851

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -28 lines)			Patch
M	ChangeLog	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/jsregexp.cc	View	4 chunks	+28 lines, -27 lines	0 comments	Download
M	src/third_party/jscre/pcre.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_compile.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_exec.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_internal.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_tables.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_ucp_searchfuncs.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/third_party/jscre/pcre_xclass.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages