Issue 1251009: Re-apply "Inline floating point compare"...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1251009: Re-apply "Inline floating point compare"... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Re-apply "Inline floating point compare" This re-applies r4220 and r4233, which was reverted in r4254 due to a bug. This bug has now been fixed, with the only change being line 2884 changed from __ SmiTag(left_side->reg()); to __ SmiTag(operand->reg()); Added a regression test. BUG=http://crbug.com/39160 TEST=test/mjsunit/regress/regress-crbug-39160.js Committed: http://code.google.com/p/v8/source/detail?r=4261

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+500 lines, -188 lines)			Patch
M	src/arm/codegen-arm.cc	View	2 chunks	+41 lines, -37 lines	0 comments	Download
M	src/codegen.h	View	3 chunks	+19 lines, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	14 chunks	+319 lines, -109 lines	0 comments	Download
M	src/jump-target.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/jump-target.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+41 lines, -37 lines	0 comments	Download
A	test/mjsunit/regress/regress-crbug-39160.js	View	1 chunk	+41 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 9 months ago (2010-03-25 12:02:20 UTC) #2

LGTM

http://codereview.chromium.org/1251009/diff/1/9
File test/mjsunit/regress/regress-crbug-39160.js (right):

http://codereview.chromium.org/1251009/diff/1/9#newcode1
test/mjsunit/regress/regress-crbug-39160.js:1: // Copyright 2009 the V8 project
authors. All rights reserved.
2010

Expand Messages | Collapse Messages