Issue 1251001: Fixed loader issue in unit tests caused by some test not using that mock and ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1251001: Fixed loader issue in unit tests caused by some test not using that mock and ... (Closed)

Created:
10 years, 9 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
DaveMoore, ericroman

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fixed loader issue in unit tests caused by some test not using that mock and causing the library to appear already loaded in a failed state. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42419

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/cros/cros_library.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/login/google_authenticator_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

eroman

lgtm. (Although I admit I am not familiar with this code).

10 years, 9 months ago (2010-03-24 01:29:04 UTC) #2