Issue 125095: Add partial presubmit support to git checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125095: Add partial presubmit support to git checkout. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add partial presubmit support to git checkout. Also fix argument processing. It doesn't works at the moment but doesn't throw an exception either. :) TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18611

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -18 lines)			Patch
	M	presubmit_support.py	View	1	4 chunks	+86 lines, -17 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		2 chunks	+20 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 6 months ago (2009-06-15 17:04:13 UTC) #2

LGTM.. i'm assuming this wont break gcl this time ;)

http://codereview.chromium.org/125095/diff/1003/5
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/125095/diff/1003/5#newcode470
Line 470: ).AndReturn(False)
weird alignment. first time i see something like that. i don't mind that much
though.

http://codereview.chromium.org/125095/diff/1003/5#newcode473
Line 473: #presubmit.ParseFiles([], None).AndReturn([])
commented out?

Expand Messages | Collapse Messages