Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6128)

Unified Diff: chrome/browser/printing/print_job_worker.cc

Issue 125082: Add Print Selection support to Chrome. This change is fairly involved since ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job_worker.h ('k') | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_worker.cc
===================================================================
--- chrome/browser/printing/print_job_worker.cc (revision 18804)
+++ chrome/browser/printing/print_job_worker.cc (working copy)
@@ -50,7 +50,7 @@
PrintJobWorker::PrintJobWorker(PrintJobWorkerOwner* owner)
: Thread("Printing_Worker"),
owner_(owner) {
- // The object is created in the UI thread.
+ // The object is created in the IO thread.
DCHECK_EQ(owner_->message_loop(), MessageLoop::current());
}
@@ -167,7 +167,7 @@
// Is the page available?
scoped_refptr<PrintedPage> page;
if (!document_->GetPage(page_number_.ToInt(), &page)) {
- // The page is implictly requested.
+ // The page is implicitly requested.
break;
}
// The page is there, print it.
@@ -192,21 +192,6 @@
printing_context_.DismissDialog();
}
-void PrintJobWorker::RequestMissingPages() {
- DCHECK_EQ(message_loop(), MessageLoop::current());
- // It may arrive out of order. Don't mind about it.
- if (page_number_ != PageNumber::npos()) {
- // We are printing.
- document_->RequestMissingPages();
- }
- NotificationTask* task = new NotificationTask();
- task->Init(owner_,
- JobEventDetails::ALL_PAGES_REQUESTED,
- document_.get(),
- NULL);
- owner_->message_loop()->PostTask(FROM_HERE, task);
-}
-
void PrintJobWorker::OnDocumentDone() {
DCHECK_EQ(message_loop(), MessageLoop::current());
DCHECK_EQ(page_number_, PageNumber::npos());
« no previous file with comments | « chrome/browser/printing/print_job_worker.h ('k') | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698