Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: views/widget/root_view.h

Issue 125062: Fix reversed focus traversal order issue. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/focus/focus_manager_unittest.cc ('k') | views/widget/root_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/root_view.h
===================================================================
--- views/widget/root_view.h (revision 18328)
+++ views/widget/root_view.h (working copy)
@@ -144,7 +144,7 @@
virtual View* FindNextFocusableView(View* starting_view,
bool reverse,
Direction direction,
- bool dont_loop,
+ bool check_starting_view,
FocusTraversable** focus_traversable,
View** focus_traversable_view);
virtual FocusTraversable* GetFocusTraversableParent();
@@ -214,22 +214,26 @@
// Returns the next focusable view or view containing a FocusTraversable (NULL
// if none was found), starting at the starting_view.
- // skip_starting_view, can_go_up and can_go_down controls the traversal of
+ // check_starting_view, can_go_up and can_go_down controls the traversal of
// the views hierarchy.
// skip_group_id specifies a group_id, -1 means no group. All views from a
// group are traversed in one pass.
View* FindNextFocusableViewImpl(View* starting_view,
- bool skip_starting_view,
+ bool check_starting_view,
bool can_go_up,
bool can_go_down,
- int skip_group_id);
+ int skip_group_id,
+ FocusTraversable** focus_traversable,
+ View** focus_traversable_view);
// Same as FindNextFocusableViewImpl but returns the previous focusable view.
View* FindPreviousFocusableViewImpl(View* starting_view,
- bool skip_starting_view,
+ bool check_starting_view,
bool can_go_up,
bool can_go_down,
- int skip_group_id);
+ int skip_group_id,
+ FocusTraversable** focus_traversable,
+ View** focus_traversable_view);
// Convenience method that returns true if a view is focusable and does not
// belong to the specified group.
« no previous file with comments | « views/focus/focus_manager_unittest.cc ('k') | views/widget/root_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698