Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: views/widget/widget_win.cc

Issue 125062: Fix reversed focus traversal order issue. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « views/widget/widget_win.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "views/widget/widget_win.h" 5 #include "views/widget/widget_win.h"
6 6
7 #include "app/gfx/canvas.h" 7 #include "app/gfx/canvas.h"
8 #include "app/gfx/path.h" 8 #include "app/gfx/path.h"
9 #include "app/win_util.h" 9 #include "app/win_util.h"
10 #include "base/gfx/native_theme.h" 10 #include "base/gfx/native_theme.h"
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 void WidgetWin::DidProcessMessage(const MSG& msg) { 468 void WidgetWin::DidProcessMessage(const MSG& msg) {
469 if (root_view_->NeedsPainting(true)) { 469 if (root_view_->NeedsPainting(true)) {
470 PaintNow(root_view_->GetScheduledPaintRect()); 470 PaintNow(root_view_->GetScheduledPaintRect());
471 } 471 }
472 } 472 }
473 473
474 /////////////////////////////////////////////////////////////////////////////// 474 ///////////////////////////////////////////////////////////////////////////////
475 // FocusTraversable 475 // FocusTraversable
476 476
477 View* WidgetWin::FindNextFocusableView( 477 View* WidgetWin::FindNextFocusableView(
478 View* starting_view, bool reverse, Direction direction, bool dont_loop, 478 View* starting_view, bool reverse, Direction direction,
479 FocusTraversable** focus_traversable, View** focus_traversable_view) { 479 bool check_starting_view, FocusTraversable** focus_traversable,
480 View** focus_traversable_view) {
480 return root_view_->FindNextFocusableView(starting_view, 481 return root_view_->FindNextFocusableView(starting_view,
481 reverse, 482 reverse,
482 direction, 483 direction,
483 dont_loop, 484 check_starting_view,
484 focus_traversable, 485 focus_traversable,
485 focus_traversable_view); 486 focus_traversable_view);
486 } 487 }
487 488
488 FocusTraversable* WidgetWin::GetFocusTraversableParent() { 489 FocusTraversable* WidgetWin::GetFocusTraversableParent() {
489 // We are a proxy to the root view, so we should be bypassed when traversing 490 // We are a proxy to the root view, so we should be bypassed when traversing
490 // up and as a result this should not be called. 491 // up and as a result this should not be called.
491 NOTREACHED(); 492 NOTREACHED();
492 return NULL; 493 return NULL;
493 } 494 }
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 } 1059 }
1059 if (WA_INACTIVE == activation_state) { 1060 if (WA_INACTIVE == activation_state) {
1060 focus_manager->StoreFocusedView(); 1061 focus_manager->StoreFocusedView();
1061 } else { 1062 } else {
1062 // We must restore the focus after the message has been DefProc'ed as it 1063 // We must restore the focus after the message has been DefProc'ed as it
1063 // does set the focus to the last focused HWND. 1064 // does set the focus to the last focused HWND.
1064 focus_manager->RestoreFocusedView(); 1065 focus_manager->RestoreFocusedView();
1065 } 1066 }
1066 } 1067 }
1067 } // namespace views 1068 } // namespace views
OLDNEW
« no previous file with comments | « views/widget/widget_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698