Fix reversed focus traversal order issue.

views/focus/focus_manager.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_FOCUS_FOCUS_MANAGER_H_
 #define VIEWS_FOCUS_FOCUS_MANAGER_H_
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
@@ skipping 89 matching lines @@
   // and focus_traversable_view should be set to the view associated with the
   // FocusTraversable.
   // This call should return NULL if the end of the focus loop is reached.
   // - |starting_view| is the view that should be used as the starting point
   //   when looking for the previous/next view. It may be NULL (in which case
   //   the first/last view should be used depending if normal/reverse).
   // - |reverse| whether we should find the next (reverse is false) or the
   //   previous (reverse is true) view.
   // - |direction| specifies whether we are traversing down (meaning we should
   //   look into child views) or traversing up (don't look at child views).
-  // - |dont_loop| if true specifies that if there is a loop in the focus
-  //   hierarchy, we should keep traversing after the last view of the loop.
+  // - |check_starting_view| is true if starting_view may obtain the next focus.
   // - |focus_traversable| is set to the focus traversable that should be
   //   traversed if one is found (in which case the call returns NULL).
   // - |focus_traversable_view| is set to the view associated with the
   //   FocusTraversable set in the previous parameter (it is used as the
   //   starting view when looking for the next focusable view).
 
   virtual View* FindNextFocusableView(View* starting_view,
                                       bool reverse,
                                       Direction direction,
-                                      bool dont_loop,
+                                      bool check_starting_view,
                                       FocusTraversable** focus_traversable,
                                       View** focus_traversable_view) = 0;
 
   // Should return the parent FocusTraversable.
   // The top RootView which is the top FocusTraversable returns NULL.
   virtual FocusTraversable* GetFocusTraversableParent() = 0;
 
   // This should return the View this FocusTraversable belongs to.
   // It is used when walking up the view hierarchy tree to find which view
   // should be used as the starting view for finding the next/previous view.
@@ skipping 170 matching lines @@
 
   // Returns the last view of the focus traversal hierarchy.
   View* FindLastFocusableView();
 
   // Returns the focusable view found in the FocusTraversable specified starting
   // at the specified view. This traverses down along the FocusTraversable
   // hierarchy.
   // Returns NULL if no focusable view were found.
   View* FindFocusableView(FocusTraversable* focus_traversable,
                           View* starting_view,
-                          bool reverse,
-                          bool dont_loop);
+                          bool reverse);
 
   // The RootView of the window associated with this FocusManager.
   RootView* top_root_view_;
 
   // The view that currently is focused.
   View* focused_view_;
 
   // The storage id used in the ViewStorage to store/restore the view that last
   // had focus.
   int stored_focused_view_storage_id_;
@@ skipping 17 matching lines @@
   // The list of registered FocusChange listeners.
   typedef std::vector<FocusChangeListener*> FocusChangeListenerList;
   FocusChangeListenerList focus_change_listeners_;
 
   DISALLOW_COPY_AND_ASSIGN(FocusManager);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_FOCUS_FOCUS_MANAGER_H_