Issue 125059: Change delayload attribute from string to list in gyp files...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125059: Change delayload attribute from string to list in gyp files... (Closed)

Created:
11 years, 6 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change delayload attribute from string to list in gyp files Change from string to list so the list can merge correctly. TBR=scherkus Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18294

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	third_party/ffmpeg/ffmpeg.gyp	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 6 months ago (2009-06-12 17:48:18 UTC) #1

LGTM

http://codereview.chromium.org/125059/diff/1/2
File third_party/ffmpeg/ffmpeg.gyp (right):

http://codereview.chromium.org/125059/diff/1/2#newcode91
Line 91: 'DelayLoadDLLs': [
looks like you have a log of spaces here.

Expand Messages | Collapse Messages