Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 125051: Fix gcl breakage. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix gcl breakage. Small refactor of ChangeInfo to not hardcode the use of GetRepositoryRoot(). TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -134 lines) Patch
M gcl.py View 12 chunks +24 lines, -15 lines 0 comments Download
M presubmit_support.py View 4 chunks +5 lines, -4 lines 0 comments Download
M tests/gcl_unittest.py View 13 chunks +93 lines, -26 lines 0 comments Download
M tests/presubmit_unittest.py View 24 chunks +40 lines, -89 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-12 15:44:07 UTC) #1
Nicolas Sylvain
LGTM
11 years, 6 months ago (2009-06-12 15:46:57 UTC) #2
M-A Ruel
11 years, 6 months ago (2009-06-12 15:58:47 UTC) #3
TBR because it's breaking people workflow.

Powered by Google App Engine
This is Rietveld 408576698