Issue 125048: Remove branching and binding with two arguments from the JumpTarget...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125048: Remove branching and binding with two arguments from the JumpTarget... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove branching and binding with two arguments from the JumpTarget class. Manually manage off-frame results at the two sites where they were used. Committed: http://code.google.com/p/v8/source/detail?r=2157

Patch Set 1 #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -60 lines)			Patch
M	src/ia32/codegen-ia32.cc	View	3 chunks	+49 lines, -28 lines	1 comment	Download
M	src/jump-target.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/jump-target.cc	View	2 chunks	+0 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 6 months ago (2009-06-12 14:05:38 UTC) #2

LGTM.

http://codereview.chromium.org/125048/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/125048/diff/1/2#newcode1983
Line 1983: Result answer = frame_->CallStub(&stub, &left_side, &right_side);
Is it worth a comment that here is where left_side and right_side are
invalidated for the first time?

Expand Messages | Collapse Messages