Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 125046: Changed the expansion of new space to depend on how much has survived scaveng... (Closed)

Created:
11 years, 6 months ago by bak
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund, kasperl
CC:
v8-dev
Visibility:
Public.

Description

Changed the expansion of new space to depend on how much has survived scavenge. This replaces the fixed expansion policy based on number of scavenges. Increased the max new space size to 8MB (only reserved space). Increased the defalt new space size to 512KB. Committed: http://code.google.com/p/v8/source/detail?r=2151

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/heap.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap.cc View 5 chunks +16 lines, -12 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
bak
11 years, 6 months ago (2009-06-12 10:59:23 UTC) #1
Kasper Lund
11 years, 6 months ago (2009-06-12 11:04:43 UTC) #2
STV!

http://codereview.chromium.org/125046/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/125046/diff/1/2#newcode740
Line 740: // Update how much has survivived scavenge.
survivived -> survived

http://codereview.chromium.org/125046/diff/1/2#newcode742
Line 742: PromotedSpaceSize() + new_space_.Size() - survived_watermark;
Maybe reorder these to make it (crystal) clear that you're adding
new_space_.Size() and the promoted space growth to the last expansion variable.

Powered by Google App Engine
This is Rietveld 408576698