Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 125045: First round of JumpTarget simplification. Remove dead functions... (Closed)

Created:
11 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

First round of JumpTarget simplification. Remove dead functions (jumps, branches, and bind with more than two arguments). Remove unneeded variable (the "watermark" on virtual frames). Committed: http://code.google.com/p/v8/source/detail?r=2153

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -205 lines) Patch
M src/arm/jump-target-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 1 3 chunks +3 lines, -9 lines 0 comments Download
M src/ia32/jump-target-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/virtual-frame-ia32.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/virtual-frame-ia32.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/jump-target.h View 6 chunks +8 lines, -43 lines 0 comments Download
M src/jump-target.cc View 10 chunks +13 lines, -134 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 6 months ago (2009-06-12 10:58:07 UTC) #1
William Hesse
11 years, 6 months ago (2009-06-12 11:23:00 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698