Issue 125044: Fix debugger after inlined keyed store change....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125044: Fix debugger after inlined keyed store change.... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix debugger after inlined keyed store change. Make sure that the IC is always hit when debugging and make sure to restore the fast case when leaving the debugger. Committed: http://code.google.com/p/v8/source/detail?r=2152

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -3 lines)			Patch
M	src/arm/ic-arm.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	2 chunks	+11 lines, -0 lines	1 comment	Download
M	src/ia32/codegen-ia32.cc	View	4 chunks	+25 lines, -2 lines	1 comment	Download
M	src/ia32/ic-ia32.cc	View	3 chunks	+26 lines, -1 line	0 comments	Download
M	src/ic.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 6 months ago (2009-06-12 11:15:28 UTC) #2

LGTM

http://codereview.chromium.org/125044/diff/16/22
File src/debug.cc (right):

http://codereview.chromium.org/125044/diff/16/22#newcode402
Line 402: }
Maybe add a comment saying why this is not required for keyed load IC.

http://codereview.chromium.org/125044/diff/16/17
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/125044/diff/16/17#newcode5778
Line 5778: // Here we use masm_-> instead of the __ macro because this is the
Maybe loose this comment as it is already in the comment above.

Expand Messages | Collapse Messages