Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 125035: A first pass at the DOM Storage V8 bindings. (Closed)

Created:
11 years, 6 months ago by jorlow
Modified:
9 years, 6 months ago
Reviewers:
levin, dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

TEST=none BUG=14006 A first pass at the DOM Storage V8 bindings. Android needs these ASAP and Chromium will need them soon. I've created my own test suite which I will be converting into layout tests over time and used this to manually test on a slightly hacked up version of Chromium running with --single-process. Before these changes are compiled into Chrome by default, I will add tests. I've taken the GYP and webview_impl out of this patch since we don't want it to be compiled in by default yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18655

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M webkit/port/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/port/bindings/v8/DOMObjectsInclude.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_custom.h View 1 chunk +13 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_index.h View 1 chunk +10 lines, -1 line 0 comments Download
M webkit/port/bindings/v8/v8_index.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/port/bindings/v8/v8_proxy.cpp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
11 years, 6 months ago (2009-06-13 16:07:26 UTC) #1
LGTM.

Powered by Google App Engine
This is Rietveld 408576698