Issue 125032: Add scripts to thunk into the non-cygwin version of svn and python....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125032: Add scripts to thunk into the non-cygwin version of svn and python.... (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review), sky, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Add scripts to thunk into the non-cygwin version of svn and python. This is slightly messy but seemingly necessary because cygwin doesn't consider a .bat file when running the command without the .bat extension. TEST=shouldn't break everything BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18337

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
A	bootstrap/win/python.new	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	bootstrap/win/python.new.bat	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A	bootstrap/win/svn.new	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	bootstrap/win/svn.new.bat	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	bootstrap/win/win_tools.bat	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

http://codereview.chromium.org/125032/diff/1/2 File bootstrap/win/win_tools.bat (right): http://codereview.chromium.org/125032/diff/1/2#newcode85 Line 85: call ren "%WIN_TOOLS_ROOT_DIR%python.new" "%WIN_TOOLS_ROOT_DIR%\python_bin" 1>nul i dont get ...

11 years, 6 months ago (2009-06-12 02:41:49 UTC) #2

M-A Ruel

11 years, 6 months ago (2009-06-12 16:26:04 UTC) #3

Ok the last version was broken. I generated a new zip file (svn_bin.zip) to make
it work without breaking the current clients.

cygwin users will have to clear their depot_tools fresh to use the new bash
scripts.

Expand Messages | Collapse Messages