Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 125010: Enable a bunch of layout tests for <audio> and <video> (Closed)

Created:
11 years, 6 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, awong
Visibility:
Public.

Description

Enable a bunch of layout tests for <audio> and <video> BUG=4363 Enabled media layout tests under the folder on Windows: LayoutTests/media LayoutTests/fast/media LayoutTests/http/tests/media Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18297

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 1 chunk +76 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alpha Left Google
11 years, 6 months ago (2009-06-11 21:26:20 UTC) #1
scherkus (not reviewing)
Have you tried running these when the DLLs are not present for regular chromium builds? ...
11 years, 6 months ago (2009-06-11 21:45:22 UTC) #2
fbarchard
my only comment is I've been trying since Tuesday night to get these to build... ...
11 years, 6 months ago (2009-06-11 21:47:36 UTC) #3
Alpha Left Google
The nit was fixed. I have another patch that does delay loading for FFmpeg dlls. ...
11 years, 6 months ago (2009-06-11 23:35:11 UTC) #4
scherkus (not reviewing)
11 years, 6 months ago (2009-06-12 01:12:32 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698