Issue 125004: Revert "BUG=12114"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125004: Revert "BUG=12114" (Closed)

Created:
11 years, 6 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Revert "BUG=12114 " This reverts commit r18189. TBR=rafaelw

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+294 lines, -464 lines)			Patch
M	chrome/browser/extensions/extension_creator.h	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_creator.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_shelf_model_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	6 chunks	+10 lines, -58 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	18 chunks	+49 lines, -203 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	8 chunks	+21 lines, -67 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View	9 chunks	+6 lines, -33 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	12 chunks	+30 lines, -48 lines	0 comments	Download
M	chrome/common/extensions/extension_unittest.cc	View	3 chunks	+19 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_unpacker.cc	View	7 chunks	+118 lines, -18 lines	0 comments	Download
M	chrome/test/data/extensions/bad/missing_content_script/1/manifest.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
A	chrome/test/data/extensions/bad_hash.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/extensions/bad_json.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/bad_magic.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/content_script_inject/manifest.json	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/good.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/good.pem	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/test/data/extensions/good/extension1/1/manifest.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/extensions/good/extension2/2/manifest.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/extensions/good/extension3/1.0/manifest.json	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/data/extensions/good2.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/page_action.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/samples/buildbot/manifest.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/samples/subscribe/manifest.json	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/theme.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/theme2.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/theme_with_extension.crx	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension1.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension2.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/ui/create_extension_detail_value_expected_output/good-extension3.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/uitest/roundtrip_api_call/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/uitest/simple_api_call/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download