Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 12496: Add v8::jscre namespace around jscre functions to avoid link errors with jsc ... (Closed)

Created:
12 years ago by Feng Qian
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add v8::jscre namespace around jscre functions to avoid link errors with jsc pcre files in Chrome. Committed: http://code.google.com/p/v8/source/detail?r=849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -27 lines) Patch
M src/jsregexp.cc View 4 chunks +28 lines, -27 lines 0 comments Download
M src/third_party/jscre/pcre.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_compile.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_exec.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_internal.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_tables.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_ucp_searchfuncs.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/jscre/pcre_xclass.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Feng Qian
12 years ago (2008-11-26 22:01:56 UTC) #1
iposva
LGTM -Ivan
12 years ago (2008-11-26 22:29:51 UTC) #2
Erik does not do reviews
12 years ago (2008-11-26 22:46:26 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698